Improve trait/impl method discrepancy errors #84014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is particularly useful for cases where arbitrary self types are used, like in custom `Future`s.
|
r? @varkor (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit bb502c4 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2021
Rollup of 7 pull requests Successful merges: - rust-lang#83669 (Issue 81508 fix) - rust-lang#84014 (Improve trait/impl method discrepancy errors) - rust-lang#84059 (Bump libc dependency of std to 0.2.93) - rust-lang#84067 (clean up example on read_to_string) - rust-lang#84079 (Improve test for `rustdoc::bare_urls` lint) - rust-lang#84094 (Remove FixedSizeArray) - rust-lang#84101 (rustdoc: Move crate loader to collect_intra_doc_links::early ) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Structured suggestions are particularly useful for cases where arbitrary self types are used, like in custom
Futures, because the way to writeself: Pin<&mut Self>is not necessarily self-evident when first encountered.